chore: fix Docker cqlsh install and improve simulation diagnostics#7691
Closed
zawadzkidiana wants to merge 1 commit intocadence-workflow:masterfrom
Closed
chore: fix Docker cqlsh install and improve simulation diagnostics#7691zawadzkidiana wants to merge 1 commit intocadence-workflow:masterfrom
zawadzkidiana wants to merge 1 commit intocadence-workflow:masterfrom
Conversation
- Install py3-setuptools, py3-wheel, and ca-certificates in Docker images so pip3 install cqlsh succeeds on newer Alpine/pip - Add --no-build-isolation to cqlsh pip install - Return structured JSON from simulation worker /health endpoint with cluster info, ready domain count, and last errors - Add per-endpoint error/status logging in simulation health check with 1s HTTP client timeout to prevent hangs Signed-off-by: Diana Zawadzki <dzawa@live.de>
zawadzkidiana
requested review from
Assem-Uber,
Shaddoll,
abhishekj720,
adhityamamallan,
arzonus,
bowenxia,
c-warren,
davidporter-id-au,
demirkayaender,
dkrotx,
eleonoradgr,
fimanishi,
gazi-yestemirova,
jakobht,
macrotim,
natemort,
neil-xie,
sankari165,
shijiesheng and
timl3136
as code owners
|
🔍 CI failure analysis for 06b0385: The codecov test failure in TestPollForDecisionTasks is a flaky test unrelated to this PR's Docker and simulation changes.IssueTest Root CauseThis failure is unrelated to the PR changes. This PR modifies:
The failing test is in the matching engine service testing poller behavior, which has no connection to Docker builds or simulation health checks. DetailsEvidence of Flakiness
The test expects a poller to wait 0ms but it waited 3ms, suggesting a timing race in the test setup or teardown. Code Review ✅ ApprovedClean infrastructure PR: Docker build fixes for Alpine 3.18 pip compatibility and improved simulation health check diagnostics with proper concurrency handling. No issues found. Rules ❌ No requirements metRepository Rules
OptionsAuto-apply is off → Gitar will not commit updates to this branch. Comment with these commands to change:
Was this helpful? React with 👍 / 👎 | Gitar |
Contributor
Author
|
fixed with: #7690 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed?
Fix Docker
cadence-auto-setupimage build and improve replication simulation test diagnostics.py3-setuptools,py3-wheel, andca-certificatesin Docker images sopip3 install cqlshsucceeds on newer Alpine/pip--no-build-isolationto cqlsh pip install/healthendpoint with cluster info, ready domain count, and last errorsWhy?
These changes were extracted from the replication histogram metric PRs (#7683, #7684) where they were originally included to unblock CI. They are prerequisites for those PRs to pass CI, but are logically independent infrastructure fixes.
The Docker
cadence-auto-setupimage build was broken on Alpine 3.18 with newer pip versions.pip3 install cqlshfails becausesetuptoolsandwheelare no longer bundled by default — they must be explicitly installed as system packages. The--no-build-isolationflag is also needed because cqlsh's build dependencies cannot be resolved in an isolated environment without pre-installed setuptools. Theca-certificatesaddition in the dockerize stage ensures HTTPS downloads (e.g. the dockerize release tarball via wget) succeed reliably. Without these fixes, all CI jobs that build or use the Docker image — including the replication simulation tests that validate the histogram additions — fail before any test code runs.The simulation worker
/healthendpoint previously returned empty 200/503 responses with no body, making it impossible to diagnose readiness failures in CI logs. When a health check failed, the test logged only "Workers are not reporting healthy yet" with no indication of whether the failure was DNS resolution, connection refused, HTTP 503, or a specific domain not being ready. The structured JSON response and per-endpoint logging make CI failures immediately actionable.